Safe access of sequencer #1625
Merged
Safe access of sequencer #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnderrauber
approved these changes
Apr 17, 2023
hautvfami
pushed a commit
to Stark-Industries-Ltd/livekit
that referenced
this pull request
Jul 21, 2023
* log some NACKs * split out NACK tracker * remove debug * debug * Sequencer safety * Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next small PR to ensure safe access of sequencer.
Can be optimised on
getPacketMetaby returning just indices into the array and later get packet meta through that pointer. Will look at it in a different PR. For now, ensuring that sequence data is not accessed directly (read or write) outside sequencer.