Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against bad quality in trackInfo #2271

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Guard against bad quality in trackInfo #2271

merged 1 commit into from
Nov 28, 2023

Conversation

boks1971
Copy link
Contributor

No description provided.

cnderrauber
cnderrauber approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@cnderrauber cnderrauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we reject the illegal AddTrackRequest ?

@boks1971
Copy link
Contributor Author

Should we reject the illegal AddTrackRequest ?

I think we should @cnderrauber . But, wanted to do a quick fix.

Will have a look at validating request and ignoring if it is not valid. As we do not send back error, it is going to be tricky.

@boks1971 boks1971 merged commit bfc4f19 into master Nov 28, 2023
2 checks passed
@boks1971 boks1971 deleted the raja_ti_quality branch November 28, 2023 16:58
boks1971 added a commit that referenced this pull request Nov 28, 2023
@boks1971
Guard against bad quality in trackInfo (#2271)
d2b553d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulwe paulwe paulwe approved these changes

@davidzhao davidzhao davidzhao approved these changes

@cnderrauber cnderrauber cnderrauber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boks1971 @paulwe @davidzhao @cnderrauber