Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean dd log #2275

Merged
merged 2 commits into from
Nov 29, 2023
Merged

clean dd log #2275

merged 2 commits into from
Nov 29, 2023

Conversation

cnderrauber
Copy link
Contributor

No description provided.

@boks1971
Copy link
Contributor

boks1971 commented Nov 29, 2023 •
edited
Loading

Can we remove this?

Maybe demote this?

Maybe demote this?

All these are logging a bunch.

davidzhao
davidzhao approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going to merge this.

@davidzhao davidzhao merged commit 0f1c1ec into master Nov 29, 2023
2 checks passed
@davidzhao davidzhao deleted the dd_log branch November 29, 2023 20:12
davidzhao added a commit that referenced this pull request Nov 29, 2023
@cnderrauber @davidzhao
clean dd log (#2275)
8234ef8 
* clean dd log

* Implemented Raja's feedback

---------

Co-authored-by: David Zhao <dz@livekit.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

@boks1971 boks1971 Awaiting requested review from boks1971

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cnderrauber @boks1971 @davidzhao