Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group SDES items for one SSRC in the same chunk. #2280

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

boks1971
Copy link
Contributor

@boks1971 boks1971 commented Dec 1, 2023

No description provided.

for _, chunk := range chunks {
numItems += len(chunk.Items)
}
batchSize = batchSize + 1 + numItems
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the count matching the older scheme by adding up items inside the chunk so that the batching behaviour does not change.

@boks1971 boks1971 merged commit 7b778c5 into master Dec 1, 2023
2 checks passed
@boks1971 boks1971 deleted the raja_sdes branch December 1, 2023 06:07
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! this is my bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants