Log cleanup pass #2285
Log cleanup pass #2285
Conversation
Demoted a bunch of logs to DEBUG, consolidated logs.
| RequestSink: reqSink, | ||
| ResponseSource: resSource, | ||
| NodeID: nodeID, | ||
| }, nil |
There was a problem hiding this comment.
it now returns nodeID, so RTCService would have that information for consolidated logging
| t.params.Logger.Errorw("error handling event", err, "event", event.String()) | ||
| if onNegotiationFailed := t.getOnNegotiationFailed(); onNegotiationFailed != nil { | ||
| onNegotiationFailed() | ||
| if !t.isClosed.Load() { |
There was a problem hiding this comment.
we are getting errors that operations couldn't be completed due to PeerConnection has closed. so handling that race better
| "lc (filtered)", t.filteredLocalCandidates.Get(), | ||
| "rc (filtered)", t.filteredRemoteCandidates.Get(), | ||
| "lc_filtered", t.filteredLocalCandidates.Get(), | ||
| "rc_filtered", t.filteredRemoteCandidates.Get(), |
There was a problem hiding this comment.
spaces in fields are harder to parse. temporary for now, I'll be changing how we handle ice candidates in a separate PR
| @@ -376,7 +382,7 @@ func (s *RTCService) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| websocket.CloseNormalClosure, | |||
| websocket.CloseNoStatusReceived, | |||
| ) { | |||
| pLogger.Infow("exit ws read loop for closed connection", "connID", cr.ConnectionID, "wsError", err) | |||
| closedByClient.Store(true) | |||
There was a problem hiding this comment.
avoid a separate line, but include reason for closure in the same entry
| if rtpStats != "" { | ||
| d.params.Logger.Infow("rtp stats", "direction", "downstream", "mime", d.mime, "ssrc", d.ssrc, "stats", rtpStats) | ||
| } | ||
| d.params.Logger.Debugw("rtp stats", |
There was a problem hiding this comment.
Go well my trusted friend!!!
| @@ -111,7 +111,7 @@ func (u *UpTrackManager) SetPublishedTrackMuted(trackID livekit.TrackID, muted b | |||
| track.SetMuted(muted) | |||
|
|
|||
| if currentMuted != track.IsMuted() { | |||
| u.params.Logger.Infow("publisher mute status changed", "trackID", trackID, "muted", track.IsMuted()) | |||
| u.params.Logger.Debugw("publisher mute status changed", "trackID", trackID, "muted", track.IsMuted()) | |||
There was a problem hiding this comment.
This one has been useful. But can get it from analytics events.
| @@ -1297,7 +1297,7 @@ func (s *StreamAllocator) initProbe(probeGoalDeltaBps int64) { | |||
| s.channelObserver = s.newChannelObserverProbe() | |||
| s.channelObserver.SeedEstimate(s.lastReceivedEstimate) | |||
|
|
|||
| s.params.Logger.Infow( | |||
| s.params.Logger.Debugw( | |||
There was a problem hiding this comment.
Need to make analytics events for these.
There was a problem hiding this comment.
yeah I left the other one alone because they contained information about the change. but seems like notifying that we are starting to probe is only useful in limited situations. would be great to have congestion_started and congestion_ended events
Demoted a bunch of logs to DEBUG, consolidated logs.