Expose detailed connection info with ICEConnectionDetails #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
commented
Dec 3, 2023
| Filtered bool | ||
| } | ||
|
|
||
| type ICEConnectionDetails struct { |
There was a problem hiding this comment.
combining all ICE details into a new data type
| return p.TransportManager.GetICEConnectionDetails() | ||
| } | ||
|
|
||
| func (p *ParticipantImpl) HasConnected() bool { |
There was a problem hiding this comment.
adding a new interface method. useful to know if Participant was ever successful
boks1971
approved these changes
Dec 3, 2023
| cds := participant.GetICEConnectionDetails() | ||
| for _, cd := range cds { | ||
| if cd.Type != types.ICEConnectionTypeUnknown { | ||
| meta.ConnectionType = string(cd.Type) |
There was a problem hiding this comment.
Would be good to have both publisher and subscriber details in analytics at some point.
| @@ -1416,3 +1426,39 @@ func BroadcastDataPacketForRoom(r types.Room, source types.LocalParticipant, dp | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| func connectionDetailsFields(cds []*types.ICEConnectionDetails) []interface{} { | |||
pkg/rtc/types/ice.go
Outdated
| } | ||
| } | ||
|
|
||
| func IsCandidateEqualTo(c1, c2 *webrtc.ICECandidate) bool { |
There was a problem hiding this comment.
These looks like local methods. Can these be lower case isICE...?
There was a problem hiding this comment.
I was thinking they are useful to others that are comparing candidates. but will make them local for now until we need it elsewhere.
cnderrauber
approved these changes
Dec 3, 2023
paulwe
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.