Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic occurs when starting livekit-server with key-file option #2313

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix panic occurs when starting livekit-server with key-file option #2313

merged 1 commit into from
Dec 21, 2023

Conversation

kkoudev
Copy link
Contributor

@kkoudev kkoudev commented Dec 14, 2023

Fix: #2312

Fixed an issue where a panic would occur when starting livekit-server with API Key and API secret specified in the key-file option.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

davidzhao
davidzhao approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@davidzhao davidzhao merged commit 5dc87d7 into livekit:master Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic occurs when starting livekit-server with key-file option.
3 participants
@kkoudev @CLAassistant @davidzhao