Add support for EnableTranscoding ingress option #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still needs an update to the protocol module. |
dennwc
approved these changes
Apr 24, 2024
go.mod
Outdated
| @@ -1,5 +1,7 @@ | |||
| module github.com/livekit/livekit-server | |||
|
|
|||
| replace github.com/livekit/protocol => ../protocol | |||
There was a problem hiding this comment.
As commented earlier, this still needs a protocol update once that PR is merged. This allows me to still test locally until this is updated.
frostbyte73
approved these changes
Apr 24, 2024
biglittlebigben
changed the title
biglittlebigben
added a commit
that referenced
this pull request
Apr 26, 2024
This release changes the default behavior when creating or updating WHIP ingress. WHIP ingress will now default to disabling transcoding and forwarding media unchanged to the LiveKit subscribers. This behavior can be changed by using the new `enable_transcoding` available in updated SDKs. The behavior of existing ingresses is unchanged. ### Added - Add support for "abs-capture-time" extension. (#2640) - Add PropagationDelay API to sender report data (#2646) - Add support for EnableTranscoding ingress option (#2681) - Pass new SIP metadata. Update protocol. (#2683) - Handle UpdateLocalAudioTrack and UpdateLocalVideoTrack. (#2684) - Forward transcription data packets to the room (#2687) ### Fixed - backwards compatability for IsRecorder (#2647) - Reduce RED weight in half. (#2648) - add disconnected chan to participant (#2650) - add typed ops queue (#2655) - ICE config cache module. (#2654) - use typed ops queue in pctransport (#2656) - Use the ingress state updated_at field to ensure that out of order RPC do not overwrite state (#2657) - Log ICE candidates to debug TCP connection issues. (#2658) - Debug logging addition of ICE candidate (#2659) - fix participant, ensure room name matches (#2660) - replace keyframe ticker with timer (#2661) - fix key frame timer (#2662) - Disable dynamic playout delay for screenshare track (#2663) - Don't log dd invalid template index (#2664) - Do codec munging when munging RTP header. (#2665) - Connection quality LOST only if RTCP is also not available. (#2670) - Handle large jumps in RTCP sender report timestamp. (#2674) - Bump golang.org/x/net from 0.22.0 to 0.23.0 (#2673) - do not capture pointers in ops queue closures (#2675) - Fix SubParticipant twice when paticipant left (#2672) - use ttlcache (#2677) - Detach subscriber datachannel to save memory (#2680) - Clean up UpdateVideoLayers (#2685) - Make datachannel optional for publisher (#2686)
Merged
biglittlebigben
added a commit
that referenced
this pull request
Apr 26, 2024
## Changelog This release changes the default behavior when creating or updating WHIP ingress. WHIP ingress will now default to disabling transcoding and forwarding media unchanged to the LiveKit subscribers. This behavior can be changed by using the new `enable_transcoding` available in updated SDKs. The behavior of existing ingresses is unchanged. ### Added - Add support for "abs-capture-time" extension. (#2640) - Add PropagationDelay API to sender report data (#2646) - Add support for EnableTranscoding ingress option (#2681) - Pass new SIP metadata. Update protocol. (#2683) - Handle UpdateLocalAudioTrack and UpdateLocalVideoTrack. (#2684) - Forward transcription data packets to the room (#2687) ### Fixed - backwards compatability for IsRecorder (#2647) - Reduce RED weight in half. (#2648) - add disconnected chan to participant (#2650) - add typed ops queue (#2655) - ICE config cache module. (#2654) - use typed ops queue in pctransport (#2656) - Use the ingress state updated_at field to ensure that out of order RPC do not overwrite state (#2657) - Log ICE candidates to debug TCP connection issues. (#2658) - Debug logging addition of ICE candidate (#2659) - fix participant, ensure room name matches (#2660) - replace keyframe ticker with timer (#2661) - fix key frame timer (#2662) - Disable dynamic playout delay for screenshare track (#2663) - Don't log dd invalid template index (#2664) - Do codec munging when munging RTP header. (#2665) - Connection quality LOST only if RTCP is also not available. (#2670) - Handle large jumps in RTCP sender report timestamp. (#2674) - Bump golang.org/x/net from 0.22.0 to 0.23.0 (#2673) - do not capture pointers in ops queue closures (#2675) - Fix SubParticipant twice when paticipant left (#2672) - use ttlcache (#2677) - Detach subscriber datachannel to save memory (#2680) - Clean up UpdateVideoLayers (#2685) - Make datachannel optional for publisher (#2686)
biglittlebigben
added a commit
that referenced
this pull request
May 1, 2024
This reverts commit f088730.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generate the corresponding
BypassTranscodingoption for backward compatibility. Ignore oldBypassTranscodingfield set in the client requests.