Set layer state to stopped on pause. #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, on pause, the worker was let run and declare layer gone 1/2 a second (or whatever the stream tracker window is set for) later. But, when rapidly changing mute/unmute, the following cuold happen and layer changes may be missed - Available layers - 0, 1, 2 - Mute - Before layer gone detected, unumute. Because of this layer gone is not reported and available layers stay at 0, 1, 2. - Stream tracker is reset on unmute to enable quick detection of layer start. - If all layers start back up, no issues. - But, if the layers do not start back up, there is no layer start firing and the available layers are still 0, 1, 2 which is incorrect.
davidzhao
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, on pause, the worker was let run and declare
layer gone 1/2 a second (or whatever the stream tracker window
is set for) later.
But, when rapidly changing mute/unmute, the following cuold happen
and layer changes may be missed
is not reported and available layers stay at 0, 1, 2.
start.
firing and the available layers are still 0, 1, 2 which is incorrect.