Autocert Support #867
Closed
Autocert Support #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
davidzhao
reviewed
Aug 6, 2022
| @@ -27,4 +27,4 @@ FROM alpine | |||
| COPY --from=builder /workspace/livekit-server /livekit-server | |||
|
|
|||
| # Run the binary. | |||
| ENTRYPOINT ["/livekit-server"] | |||
| ENTRYPOINT ["/bin/sh","-c","./livekit-server --config $CONFIG --node-ip $NODEIP >> /tmp/livekit.log 2>&1"] | |||
There was a problem hiding this comment.
Is this test code? we do not want to modify our build script.
| @@ -0,0 +1,19 @@ | |||
| .MAIN: build | |||
| @@ -44,6 +44,7 @@ type Config struct { | |||
| KeyFile string `yaml:"key_file,omitempty"` | |||
| Keys map[string]string `yaml:"keys,omitempty"` | |||
| Region string `yaml:"region,omitempty"` | |||
| AutocertCache string `yaml:"autocert_cache,omitempty"` | |||
There was a problem hiding this comment.
It's not clear that this enables auto ssl, we'd also want to group this config with future configuration parameters such as using another provider than LetsEncrypt.
Suggested change
| AutocertCache string `yaml:"autocert_cache,omitempty"` | |
| AutoCert AutoCertConfig `yaml:"autocert"` |
Enabled bool
CacheDirectory string
``
|
Done.
#898
Thank you!
…On Sun, Aug 7, 2022 at 1:01 AM David Zhao ***@***.***> wrote:
***@***.**** commented on this pull request.
looks good! a few changes to the config structure.
would this work with TURN as well? that'll be a huge simplification to
automatically generate certificate for TURN/TLS
------------------------------
In Dockerfile
<#867 (comment)>:
> @@ -27,4 +27,4 @@ FROM alpine
COPY --from=builder /workspace/livekit-server /livekit-server
# Run the binary.
-ENTRYPOINT ["/livekit-server"]
+ENTRYPOINT ["/bin/sh","-c","./livekit-server --config $CONFIG --node-ip $NODEIP >> /tmp/livekit.log 2>&1"]
Is this test code? we do not want to modify our build script.
------------------------------
In Makefile
<#867 (comment)>:
> @@ -0,0 +1,19 @@
+.MAIN: build
same for this file.
------------------------------
In pkg/config/config.go
<#867 (comment)>:
> @@ -44,6 +44,7 @@ type Config struct {
KeyFile string `yaml:"key_file,omitempty"`
Keys map[string]string `yaml:"keys,omitempty"`
Region string `yaml:"region,omitempty"`
+ AutocertCache string `yaml:"autocert_cache,omitempty"`
It's not clear that this enables auto ssl, we'd also want to group this
config with future configuration parameters such as using another provider
than LetsEncrypt.
⬇️ Suggested change
- AutocertCache string `yaml:"autocert_cache,omitempty"`
+ AutoCert AutoCertConfig `yaml:"autocert"`
Enabled bool
CacheDirectory string
``
—
Reply to this email directly, view it on GitHub
<#867 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMZ7IE6Y2WJGZA374Q2A2TVX3OEVANCNFSM55OONKIQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling an option to use Autocert Certificates
The option is ON, if config contains a line like
autocert_cache: /tmp/certs