don't run builds outside of cibuildwheel #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #136 |
theomonnom
commented
Jan 12, 2024
| # cibuildwheel is crosscompiling to arm64 on macos, make sure we download the | ||
| # right binary (kind of a hack here...) | ||
| if os.environ.get("CIBUILDWHEEL") == "1" and "arm64" in os.environ.get( | ||
| "ARCHFLAGS", "" |
There was a problem hiding this comment.
Code moved inside the rust-sdks for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#134 #129 was causing issues when loading the FFI binary. This PR fixes it
Now not running the download process inside build_py (only doing it inside cibuildwheel)
Also see livekit/rust-sdks#283