feat: use libwebrtc m114 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidzhao
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
looks good!
@theomonnom do you mean our webrtc-sdk builds would need to update to C++ 20 too?
|
No, only the ones inside this repo (I'm using the use_cxx17 flag atm) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled codecs atm: vp8 & h264
NOTE: This PR uses c++20 to fix some issues on Windows (The webrtc code use c++20 features like designated initializers).
For now the libwebrtc build scripts use c++17 for compiling, we will definitely need to change the scripts to use c++20 in the future. (see #129)