Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Tokio types in a configurable runtime #310

Merged
merged 15 commits into from
Mar 28, 2024

Conversation

mikayla-maki
Copy link
Contributor

@mikayla-maki mikayla-maki commented Feb 15, 2024

Adds a thin compatibility layer over the rust runtime ecosystem.

TODO:

  • Add support for async_std compatible runtimes
  • Resolve any TODOs
  • Get the async_std examples running
  • Make sure this works for Zed
  • Pass CI
  • Switch from async default to tokio default N/A, CI is currently broken

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm, going to test the changes with the python-sdk and merge the PR
thanks!

// and print all incoming events

fn main() {
async_std::task::block_on(async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@theomonnom theomonnom merged commit fa49b7e into livekit:main Mar 28, 2024
8 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants