Skip to content

Commit

Permalink
Deprecate prores support (#1298)
Browse files Browse the repository at this point in the history
  • Loading branch information
thomshutt committed Jun 19, 2024
1 parent e6d1726 commit 2dbf76f
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion video/probe.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
)

var (
unsupportedVideoCodecList = []string{"mjpeg", "jpeg", "png"}
unsupportedVideoCodecList = []string{"mjpeg", "jpeg", "png", "prores"}
supportedFormats = []string{"mp4", "mov", "hls"}
)

Expand Down
15 changes: 15 additions & 0 deletions video/probe_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,21 @@ func TestItRejectsWhenMJPEGVideoTrackPresent(t *testing.T) {
require.ErrorContains(t, err, "jpeg is not supported")
}

func TestItRejectsProresVideos(t *testing.T) {
_, err := parseProbeOutput(&ffprobe.ProbeData{
Format: &ffprobe.Format{
Size: "1",
},
Streams: []*ffprobe.Stream{
{
CodecType: "video",
CodecName: "prores",
},
},
})
require.ErrorContains(t, err, "prores is not supported")
}

func TestItRejectsWhenFormatMissing(t *testing.T) {
_, err := parseProbeOutput(&ffprobe.ProbeData{
Streams: []*ffprobe.Stream{
Expand Down

0 comments on commit 2dbf76f

Please sign in to comment.