Populate 'Outputs' section of callback #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
===================================================
+ Coverage 38.98635% 39.40182% +0.41547%
===================================================
Files 24 24
Lines 1539 1538 -1
===================================================
+ Hits 600 606 +6
+ Misses 861 853 -8
- Partials 78 79 +1
Continue to review full report at Codecov.
|
emranemran
approved these changes
Oct 31, 2022
iameli
pushed a commit
that referenced
this pull request
Feb 7, 2023
* cmd: Create healthtester cmd based on recordtester Basically copied the whole command and then went through it rewriting some code as a way to understand the logic. Also copied some helpers from analyzer code (contextUntilSig) * healthtester: Create helper for running multiple tests * recordtester: Improve PagerDuty formatting/links * recordtester: Allow cancelling in between tests * testers: Create Stream2Options * testers: Create Finite iface and receive on streamer2 * cmd: Remove healthchecker new command Can check any code on history if necessary * testers: Dummy stream health tester for arch review * DEV-REVERT: Use local livepeer-data lib * testers: Simplify additional tests glue * testers: Implement health tester for real * cmd/recordtester: Plug everything together * Revert "DEV-REVERT: Use local livepeer-data lib" This reverts commit b6cb78c8b0ae7e2d2aad575c9695c1d56cc5d640. * go.mod: Use beta (unmerged) version of livepeer-data * cmd/recordtester: Simplify analyzer URL flag passing * testers: Improve logs on stream health tester * testers: Fix unhealthy timer * testers: Log all errors after half the wait time * testers: Add insane log * record-tester: moar insane logs * recordtester: Ignore commas in env vars * Revert "record-tester: moar insane logs" This reverts commit f516d3f0242cf662b9651c8a5fa00c5032e8f16c. * testers: Improve formatting of stream health errors Aggregate regions for each error message and try to make it clearer that we are testing stream health global API, not multistream. * testers: A couple more formatting improvements * record-tester: Improve pagerduty API usage Use a dedup key so we dont spam the oncall engineer and also make sure to resolve incidents automatically once the tests start working. * testers: Improve formatting of regions list Just say all regions when it's all regions * go.mod: Update analyzer client version * recordtester: Add option to only send lopri PagerDuty alerts * recordtester: Include pagerduty component in alert Will differentiate messages on #incident-response based on the component, which we'll configure to be GCP/Datapacket. * health-tester: Make sure to compare health with same time Otherwise absolutely every error message is going to be slightly different. * record-tester: Remove all fatal logs from m3utester2 * record-tester: Use different dedup key when lopri Otherwise it could get confusing that the incident with the [LOPRI] prefix sends a high urgency alert. * record-tester: Make sure to finish on fatal errors * record-tester: Ensure a global test timeout * record-tester: Looser global timeout and proper log * record-tester: Accumulate errors from finite testers * record-tester: Bring back early test of crt.ctx.Err Cleaner discord msgs * stream-tester: Add hostname to start&end logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #115