Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculating bitrate of transcoded results #135

Merged
merged 2 commits into from Nov 2, 2022
Merged

Conversation

AlexKordic
Copy link
Contributor

Produced multivariant playlist now contains proper bitrate:

#EXTM3U
#EXT-X-VERSION:3
#EXT-X-STREAM-INF:PROGRAM-ID=0,BANDWIDTH=2188957288,RESOLUTION=1280x720,NAME="0-720p",FRAME-RATE=30.000
rendition-0/rendition.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=0,BANDWIDTH=745890531,RESOLUTION=640x360,NAME="1-360p",FRAME-RATE=30.000
rendition-1/rendition.m3u8
#EXT-X-STREAM-INF:PROGRAM-ID=0,BANDWIDTH=3884863845,RESOLUTION=2048x858,NAME="2-source"
rendition-2/rendition.m3u8

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #135 (208b914) into main (fe520dd) will increase coverage by 0.66821%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #135         +/-   ##
===================================================
+ Coverage   42.07617%   42.74438%   +0.66821%     
===================================================
  Files             26          26                 
  Lines           1628        1647         +19     
===================================================
+ Hits             685         704         +19     
  Misses           862         862                 
  Partials          81          81                 
Impacted Files Coverage Δ
transcode/manifest.go 74.19355% <100.00000%> (+0.28051%) ⬆️
transcode/transcode.go 66.85393% <100.00000%> (+3.72893%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe520dd...208b914. Read the comment docs.

Impacted Files Coverage Δ
transcode/manifest.go 74.19355% <100.00000%> (+0.28051%) ⬆️
transcode/transcode.go 66.85393% <100.00000%> (+3.72893%) ⬆️

transcode/transcode.go Outdated Show resolved Hide resolved
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Alex

@AlexKordic AlexKordic merged commit d38bab6 into main Nov 2, 2022
@hjpotter92 hjpotter92 deleted the ak/bitrate_calc branch May 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants