Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop transcoding on first error #174

Merged
merged 3 commits into from Nov 14, 2022
Merged

Stop transcoding on first error #174

merged 3 commits into from Nov 14, 2022

Conversation

AlexKordic
Copy link
Contributor

@AlexKordic AlexKordic commented Nov 14, 2022 •
edited

  • Stop all workers on first error
  • Fix progress calculation
  • Unit tests

Fixes #173

@AlexKordic
Stop transcoding on first error
f283464 
Fix progress calculation: count completed segments without relying on segment index
Unit tests
@AlexKordic
correct input to calculateCompletedRatio()
0c0d249 
separate `Start()` method for spawning goroutines
@AlexKordic
Fix unit tests
ace7da6
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #174 (ace7da6) into main (a012e6c) will increase coverage by 1.20755%.
The diff coverage is 82.27848%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #174         +/-   ##
===================================================
+ Coverage   46.97259%   48.18014%   +1.20755%     
===================================================
  Files             23          24          +1     
  Lines           1569        1621         +52     
===================================================
+ Hits             737         781         +44     
- Misses           738         743          +5     
- Partials          94          97          +3
Impacted Files Coverage Δ
transcode/transcode.go 64.13043% <53.33333%> (-2.70630%) ⬇️
transcode/transcode_jobs.go 89.06250% <89.06250%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a012e6c...ace7da6. Read the comment docs.

Impacted Files Coverage Δ
transcode/transcode.go 64.13043% <53.33333%> (-2.70630%) ⬇️
transcode/transcode_jobs.go 89.06250% <89.06250%> (ø)

thomshutt
thomshutt approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot and great to get the parallelism factored out into its own method

@AlexKordic AlexKordic merged commit 4ad9a0b into main Nov 14, 2022
iameli pushed a commit that referenced this pull request Feb 7, 2023
@hjpotter92
workflow/docker: github matrix array to deal with docker images (#174)
95624c2
@hjpotter92 hjpotter92 deleted the ak/parallel_jobs_refactor branch May 30, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomshutt thomshutt thomshutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop transcoding on first error
2 participants
@AlexKordic @thomshutt