Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub "Transcode Complete" callback #35

Merged
merged 8 commits into from Sep 7, 2022
Merged

Stub "Transcode Complete" callback #35

merged 8 commits into from Sep 7, 2022

Conversation

thomshutt
Copy link
Contributor

This is so we can do any final iterations on how the output will look and slightly unblock Studio

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #35 (8821562) into main (1753b3b) will decrease coverage by 6.35473%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #35         +/-   ##
===================================================
- Coverage   51.07914%   44.72441%   -6.35474%     
===================================================
  Files              8           8                 
  Lines            556         635         +79     
===================================================
  Hits             284         284                 
- Misses           235         314         +79     
  Partials          37          37                 
Impacted Files Coverage Δ
clients/callback_client.go 63.06306% <0.00000%> (-14.71473%) ⬇️
handlers/handlers.go 29.50000% <0.00000%> (-12.04931%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1753b3b...8821562. Read the comment docs.

Impacted Files Coverage Δ
clients/callback_client.go 63.06306% <0.00000%> (-14.71473%) ⬇️
handlers/handlers.go 29.50000% <0.00000%> (-12.04931%) ⬇️

clients/callback_client.go Outdated Show resolved Hide resolved
clients/callback_client.go Outdated Show resolved Hide resolved
clients/callback_client.go Outdated Show resolved Hide resolved
clients/callback_client.go Outdated Show resolved Hide resolved
clients/callback_client.go Show resolved Hide resolved
@thomshutt
Copy link
Contributor Author

@victorges I'm going to merge this now all the comments are addressed, just to avoid conflicts with other in-flight PRs but can change anything else you want in a followup PR

@thomshutt thomshutt merged commit f8d600f into main Sep 7, 2022
@thomshutt thomshutt deleted the stub-callbacks branch September 7, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants