Recording start callback #49
Conversation
Triggers: Use switch to branch to proper pipeline logic based on stream name Move string constant from UploadVOD() to config
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
===================================================
+ Coverage 32.07354% 33.17121% +1.09767%
===================================================
Files 16 17 +1
Lines 979 1028 +49
===================================================
+ Hits 314 341 +27
- Misses 628 646 +18
- Partials 37 41 +4
Continue to review full report at Codecov.
|
| log.Printf("RecordingPushOutStart addUuidToUrl() %v", err) | ||
| return destination | ||
| } | ||
| go clients.DefaultCallbackClient.SendRecordingEvent(event) |
There was a problem hiding this comment.
I wonder if we should make these hooks blocking instead. As in if they fail we should not let the stream go through either. Only opening for consideration tho, not sure what i prefer.
There was a problem hiding this comment.
Good practice is to return as soon as possible so mistserver can continue without additional latency increase.
Lets consider a watchdog process that kills bad streams separately from our happy-path.
No description provided.