Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test framework #67

Merged
merged 2 commits into from Oct 18, 2022
Merged

Integration test framework #67

merged 2 commits into from Oct 18, 2022

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented Oct 17, 2022

To run locally: make
To run against Canary: make test-canary


// Check which environment we're running in
if strings.ToLower(os.Getenv("CUCUMBER_ENV")) == "canary" {
baseURL = "http://TODO"
Copy link
Contributor Author

@thomshutt thomshutt Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the only thing remaining to be able to point at Canary

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #67 (c67e490) into main (05d2a0e) will increase coverage by 0.86170%.
The diff coverage is 85.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #67         +/-   ##
===================================================
+ Coverage   35.58119%   36.44289%   +0.86169%     
===================================================
  Files             17          17                 
  Lines           1127        1147         +20     
===================================================
+ Hits             401         418         +17     
- Misses           680         682          +2     
- Partials          46          47          +1     
Impacted Files Coverage Δ
cache/transcoding.go 49.25373% <85.00000%> (+15.21117%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36df739...c67e490. Read the comment docs.

Impacted Files Coverage Δ
cache/transcoding.go 49.25373% <85.00000%> (+15.21117%) ⬆️

Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomshutt thomshutt merged commit b9b4443 into main Oct 18, 2022
@thomshutt thomshutt deleted the integration-tests branch October 18, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants