Check status for Segmenting PUSH_END trigger #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomshutt
commented
Oct 18, 2022
| @@ -65,7 +65,9 @@ func InitializeScenario(ctx *godog.ScenarioContext) { | |||
| fmt.Println("Error while killing app process:", err.Error()) | |||
| } | |||
| if err := app.Wait(); err != nil { | |||
| fmt.Println("Error while waiting for app to exit:", err.Error()) | |||
| if err.Error() != "signal: killed" { | |||
There was a problem hiding this comment.
This is just to suppress an error being printed when the app has aactually already been successfully killed
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
===================================================
+ Coverage 37.03382% 37.25322% +0.21940%
===================================================
Files 17 17
Lines 1153 1165 +12
===================================================
+ Hits 427 434 +7
- Misses 680 685 +5
Partials 46 46
Continue to review full report at Codecov.
|
AlexKordic
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.