Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalyst-node: crash on serf failures #262

Merged
merged 3 commits into from Nov 18, 2022
Merged

catalyst-node: crash on serf failures #262

merged 3 commits into from Nov 18, 2022

Conversation

iameli
Copy link
Member

@iameli iameli commented Nov 10, 2022

This avoids the 500 error we've been seeing a lot.

@iameli iameli force-pushed the eli/crash-if-no-serf branch 2 times, most recently from b2bb77b to cbb1c93 Compare November 10, 2022 07:53
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #262 (76cd4a0) into main (d2dfb43) will decrease coverage by 0.43795%.
The diff coverage is 2.94118%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #262         +/-   ##
===================================================
- Coverage   34.23326%   33.79531%   -0.43795%     
===================================================
  Files              4           4                 
  Lines            926         938         +12     
===================================================
  Hits             317         317                 
- Misses           567         579         +12     
  Partials          42          42                 
Impacted Files Coverage Δ
cmd/catalyst-node/catalyst-node.go 19.07131% <2.94118%> (-0.38723%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2dfb43...76cd4a0. Read the comment docs.

Impacted Files Coverage Δ
cmd/catalyst-node/catalyst-node.go 19.07131% <2.94118%> (-0.38723%) ⬇️

@iameli iameli force-pushed the eli/crash-if-no-serf branch 2 times, most recently from b93bd7c to 7d8a961 Compare November 14, 2022 23:16
@iameli iameli requested review from hjpotter92, leszko and red-0ne and removed request for hjpotter92 November 14, 2022 23:18
@iameli iameli merged commit a3b2012 into main Nov 18, 2022
@iameli iameli deleted the eli/crash-if-no-serf branch November 18, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant