fix: fix active treasury proposals indicator

[rickstaa]

This commit ensures that the active treasury proposals indicator is working correctly. The changes in this proposal are also included in #247. This pull request was created so that it can already be merged while we still discuss the exact implementation of the Drawer treasury item in #247.

Before

After

[vercel]

@rickstaa is attempting to deploy a commit to the Livepeer Team on Vercel.

A member of the Team first needs to authorize it.

[rickstaa]

@dob and @victorges, I've compiled a comprehensive report to bolster confidence in merging this pull request. The critical component of this pull request is derived from existing, peer-reviewed code in our repository:

explorer/pages/treasury/index.tsx

Lines 20 to 25 in a16b534

	const { data } = useTreasuryProposalsQuery({ pollInterval });
	const proposals = useMemo(
	() => data?.treasuryProposals.map((p) => parseProposalText(p)),
	[data?.treasuryProposals]
	);

Utilizing the useTreasuryProposalsQuery hook aligns seamlessly with the already reviewed code, ensuring stable integration. I've shared the detailed testing process for additional code validation below.

Detailed Test Report

Execution Steps for Testing

1. Cloned the explorer repository for a baseline environment.
2. I installed all JavaScript dependencies to mirror the production setup.
3. Configured the necessary environment variables in the .env file for accurate simulation.
4. Launched the explorer locally using the yarn dev command, creating a representative testing environment.

Comprehensive Testing Checklist

• Initial Functionality Test: Confirmed the code's operational integrity without any apparent issues.
• Indicator Accuracy Verification: Ensured the indicator reliably reflects the correct values.
• Resilience Check for currentRound?.id: Validated that the code remains stable when currentRound?.id is undefined.
• Stability Test for proposalsData?.treasuryProposals: Assured that undefined proposalsData?.treasuryProposals doesn't cause crashes.
• Empty p.voteEnd Handling: Tested for the scenario where p.voteEnd is missing. Confirmed that in such cases, it defaults to 0, leading to totalActiveProposals being 0 without causing system instability.
• totalActiveProposals Undefined Scenario: Verified the code's robustness in instances where totalActiveProposals is undefined.

[victorges]

Neat!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
explorer-arbitrum-one	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2023 8:38pm

[rickstaa]

@victorges, I've implemented the revisions you suggested. Could you take a look at commit b3d868b and let me know if there's anything else that requires modification?

[victorges]

LGTM!