added encrypted key to struct #41
Conversation
| @@ -270,8 +270,9 @@ type ( | |||
| UploadTaskParams struct { | |||
| URL string `json:"url,omitempty"` | |||
| Encryption struct { | |||
| Key string `json:"key"` | |||
| Algorithm string `json:"algorithm,omitempty"` | |||
| EncryptedKey string `json:"encryptedKey,omitempty"` | |||
There was a problem hiding this comment.
Should we have the public key used for encryption as a field here as well? Would be future-proof and safer
| Key string `json:"key"` | ||
| Algorithm string `json:"algorithm,omitempty"` | ||
| EncryptedKey string `json:"encryptedKey,omitempty"` | ||
| Key string `json:"key,omitempty"` |
There was a problem hiding this comment.
Can you add a comment saying why this is still here? We should not have both/never pass unencrypted keys around, so it needs at least a TODO to remove it once we kill the other experiment.
There was a problem hiding this comment.
To me, it's also not clear why we need both encrypted and decrypted keys here. Looking at the design VOD Access Control V2, I don't see any place where Catalyst would need to fetch encrypted and descrypted keys from Studio. Could you maybe update the design or add some comments here?
There was a problem hiding this comment.
I think this was a reminiscent of an old experiment I had implemented where the key came unencrypted in this field. No one is using the experiment anymore and I don't think it should stay around, so I'd rather remove the field (and the whole experiment) and avoid the confusion in the schema.
gioelecerati
force-pushed
the
gio/encryption
branch
from
28ca646
to
87b3a7e
Compare
No description provided.