Fixed a transcoding bug that occurred when remote transcoder was remo…

…ved (#2747)

* Fixed a transcoding bug that occured when remote transcoder was removed

---------

Co-authored-by: Elite Encoder <john@eliteencoder.net>

CHANGELOG_PENDING.md

@@ -15,14 +15,14 @@
 #### Transcoder
 
 ### Bug Fixes 🐞
+- #2747 Fixed a transcoding bug that occurred when remote transcoder was removed
 
 #### CLI
 
 #### General
 - \#2713 Add support for keyfiles with -ethKeystorePath, update flag descriptions, flagset output to stdout
 
 #### Broadcaster
-- \#2709 Add logging for high keyframe interval, reduce log level for discovery loop
 - \#2684 Fix transcode success rate metric
 
 #### Orchestrator

core/orchestrator.go

@@ -913,25 +913,14 @@ func (rtm *RemoteTranscoderManager) Manage(stream net.Transcoder_RegisterTransco
 
 func removeFromRemoteTranscoders(rt *RemoteTranscoder, remoteTranscoders []*RemoteTranscoder) []*RemoteTranscoder {
 	if len(remoteTranscoders) == 0 {
-		// No transocerds to remove, return
+		// No transcoders to remove, return
 		return remoteTranscoders
 	}
 
-	lastIndex := len(remoteTranscoders) - 1
-	last := remoteTranscoders[lastIndex]
-	if rt == last {
-		return remoteTranscoders[:lastIndex]
-	}
-
 	newRemoteTs := make([]*RemoteTranscoder, 0)
-	for i, t := range remoteTranscoders {
-		if t == rt {
-			if i == 0 {
-				return remoteTranscoders[1:]
-			}
-			newRemoteTs = remoteTranscoders[:i]
-			newRemoteTs = append(newRemoteTs, remoteTranscoders[i+1:]...)
-			break
+	for _, t := range remoteTranscoders {
+		if t != rt {
+			newRemoteTs = append(newRemoteTs, t)
 		}
 	}
 	return newRemoteTs