-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd, eth: orchestrator activated/deactivated watcher #1173
Conversation
Changed the target branch to |
2ebd7fc fixes TranscoderDeactivated test for removed logs (stubClient.Orch was missing an Address field) and use |
9d860c1 properly sets an O's Otherwise |
efea741
to
5283a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good - let's rebase
0fa1082
to
c89e5de
Compare
rebased !
…On Wed, Nov 13, 2019 at 9:07 PM Yondon Fu ***@***.***> wrote:
***@***.**** commented on this pull request.
Changes look good - let's rebase
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1173?email_source=notifications&email_token=AFJZZWXVWF3KZ2WB4GMXB3TQTRM63A5CNFSM4JJWLVUKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLO36TY#pullrequestreview-316522319>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJZZWWRI5FJWHJVVJFLLOTQTRM63ANCNFSM4JJWLVUA>
.
|
c89e5de
to
eb67060
Compare
done ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
What does this pull request do? Explain your changes. (required)
This PR adds an implementation for an
OrchestratorWatcher
that watches for on-chain emittedTranscoderActivated
andTranscoderDeactivated
events and updates orchestrators stored in the database accordingly.Specific updates (required)
TranscoderActivated
andTranscoderDeactivated
toeth/watchers/topics.go
OrchestratorStore
interface toeth/watchers/types
to be able to stub outcommon.DB
for easier unit testingOrchestratorWatcher
typeOrchestratorWatcher
inlivepeer.go
StubOrchestratorStore
and helpers for creating stubbed outTranscoderActivated/TranscoderDeactivated
events toeth/watchers/stub.go
ActivationRound
andDeactivationRound
fields totypes.Transcoder
LivepeerEthClient.GetTranscoder()
now also returnsActivationRound
andDeactivationRound
How did you test each of these updates (required)
Ran unit tests
Does this pull request close any open issues?
Fixes #1150
Checklist:
./test.sh
pass