db: orchestrator count sql query #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
yondonfu
requested changes
Nov 11, 2019
yondonfu
requested changes
Nov 12, 2019
kyriediculous
force-pushed
the
nv/db-orchestrator-updates
branch
from
efea741
to
5283a56
Compare
|
Let's rebase |
kyriediculous
force-pushed
the
nv/orchcount-query
branch
from
dfd3cc5
to
372208c
Compare
|
rebased !
…On Wed, Nov 13, 2019 at 9:13 PM Yondon Fu ***@***.***> wrote:
Let's rebase
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1180?email_source=notifications&email_token=AFJZZWSL3RIWHOFKILAX3FLQTRNVTA5CNFSM4JKPGIOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED7PY3Y#issuecomment-553581679>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJZZWVH645EXVAMBBNOHVDQTRNVTANCNFSM4JKPGIOA>
.
|
kyriediculous
force-pushed
the
nv/orchcount-query
branch
from
372208c
to
6c9354c
Compare
|
Hmm not sure what went wrong there, dropped after rebasing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR adds an SQL query that gets a count of orchestrators according to the passed in
DBOrchFilterSpecific updates (required)
db.OrchCount(filter *DBOrchFilter) (int, error)that returns the number or orchestrators in the db that passfilterOrchCountHow did you test each of these updates (required)
ran unit tests
Does this pull request close any open issues?
Fixes #1153
Checklist:
./test.shpass