Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes (ticket validation, default flag values, devtool updates, etc.) #1201

Merged
merged 7 commits into from
Nov 19, 2019

Conversation

yondonfu
Copy link
Member

@yondonfu yondonfu commented Nov 15, 2019

What does this pull request do? Explain your changes. (required)

This PR implements a few small fixes - each fix is contained within a self-contained commit, but I chose to group these commits together.

Specific updates (required)

  • cdbc512: Compare max faceValue against the faceValue of a single ticket when validating ticket params even if the broadcaster is sending multiple tickets
  • d2e8a44: Include values when logging errors for failed max faceValue and max ticket EV validation to give users a better sense of what is going wrong when these errors occur
  • 2fb674c: Log the actual error encountered by blockwatch.Watcher. At the moment, we just log that something went wrong. This update will help diagnose the details of went wrong
  • 17b1798: Do not return an error when watchers.UnbondingWatcher tries to process an event that it is not tracking. Since we are now watching for TranscoderActivated and TranscoderDeactivated events from the BondingManager, it is possible for watchers.UnbondingWatcher to receive one of these events which it can just ignore
  • e30bb79: Update the defaults for -ticketEV, -maxTicketEV and -depositMultiplier to more reasonable values that make it easier for a user to get started
  • fb5fe0a: Log # of responses during discovery instead of an array of all protobuf messages received. This will reduce log clutter - most of the protobuf message is not easily decipherable
  • 8557724: Update the devtool script to use HTTP urls for the ETH RPC provider and to set -blockPollingInterval to 1 second since the dev chain to be used with the script has 1 second block times

How did you test each of these updates (required)

Updated unit tests and ran the devtool script.

Does this pull request close any open issues?

Fixes #1179
Fixes #1176
Fixes #1177

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Contributor

@kyriediculous kyriediculous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕵

@yondonfu yondonfu merged commit c361edf into master Nov 19, 2019
@yondonfu yondonfu deleted the yf/small-fixes branch November 19, 2019 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants