Small fixes (ticket validation, default flag values, devtool updates, etc.) #1201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR implements a few small fixes - each fix is contained within a self-contained commit, but I chose to group these commits together.
Specific updates (required)
blockwatch.Watcher
. At the moment, we just log that something went wrong. This update will help diagnose the details of went wrongwatchers.UnbondingWatcher
tries to process an event that it is not tracking. Since we are now watching forTranscoderActivated
andTranscoderDeactivated
events from the BondingManager, it is possible forwatchers.UnbondingWatcher
to receive one of these events which it can just ignore-ticketEV
,-maxTicketEV
and-depositMultiplier
to more reasonable values that make it easier for a user to get started-blockPollingInterval
to 1 second since the dev chain to be used with the script has 1 second block timesHow did you test each of these updates (required)
Updated unit tests and ran the devtool script.
Does this pull request close any open issues?
Fixes #1179
Fixes #1176
Fixes #1177
Checklist:
./test.sh
pass