Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: fixed order for video profiles when setting broadcaster config in CLI #1267

Merged
merged 1 commit into from Dec 12, 2019

Conversation

kyriediculous
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Prints the video profiles list in a fixed order when setting broadcaster config through the CLI

Specific updates (required)

  • sort result from /getAvailableTranscodingOptions

How did you test each of these updates (required)
Ran set bcast config twice, observe that output is printed in the same order

Does this pull request close any open issues?
Fixes #1144

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to merge pending green CI!

@kyriediculous kyriediculous merged commit 8469f77 into master Dec 12, 2019
@kyriediculous kyriediculous deleted the nv/fix-profile-list branch December 12, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identifiers and ordering of broadcast renditions in the CLI broadcast config keep changing
2 participants