cmd/cli: ETH & LPT unit formatting for pending fees and pending stake #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
requested changes
Jan 16, 2020
kyriediculous
force-pushed
the
nv/cli-fixes
branch
2 times, most recently
from
919323c
to
090a008
Compare
kyriediculous
force-pushed
the
nv/cli-fixes
branch
from
090a008
to
d8d3dcb
Compare
kyriediculous
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR attempts to add small improvements to the CLI by adding unit formatting and double checking if streamflow vocabulary is used ubiquitously everywhere.
Specific updates (required)
pendingFeesandpendingStakeno longer reverts I removed the need to set this to-1is the call reverts (empty output)eth.FormatUnitsto the delegator stats sectionlist registered transcodersoption tolist active transcodersHow did you test each of these updates (required)
ran CLI
Does this pull request close any open issues?
Fixes #1301
Checklist:
./test.shpass