discovery: add logging at DEBUG level for orchestrator pool predicate function when using default on-chain selection #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
requested changes
Jan 30, 2020
|
Submitted change requests and removed recipient address in favor of orchestrator service uri fc7677c |
yondonfu
requested changes
Feb 3, 2020
yondonfu
reviewed
Feb 3, 2020
… function when using default on-chain selection
kyriediculous
force-pushed
the
nv/log-pred
branch
from
3829307
to
a1db99b
Compare
|
rebased !
…On Mon, Feb 3, 2020 at 10:37 PM Yondon Fu ***@***.***> wrote:
***@***.**** commented on this pull request.
Changes look good. Let's rebase
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1335?email_source=notifications&email_token=AFJZZWS4VWM5OGTONI3S4JLRBCFCLA5CNFSM4KNKTDT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUB7JTQ#pullrequestreview-352580814>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJZZWQTYFPYLVYOQV2C4ZTRBCFCLANCNFSM4KNKTDTQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR adds logging at the
DEBUGlevel when eithersender.ValidateTicketParamsor the broadcastermaxPricecheck fails in theOrchestratorPoolpredicate function that is used in default on-chain selection mode to filter out orchestrators that aren't usable for our B.This adds a little more insight when no orchestrators are found due to them all failing this predicate function, currently it would only log
0 responses , err=<nil>.Not necessary to include this but since I added it for debugging purposes I might as well open a PR for it.
How did you test each of these updates (required)
used them to debug labrador deployment
Does this pull request close any open issues?
Checklist:
./test.shpass