Allow to specify HIGHEST_CHAIN_TAG for localdocker make target #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we give CI checks a kick with an empty commit ? Changes look good but need green CI. |
|
@kyriediculous now green |
kyriediculous
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Make possible to build local docker image with HIGHEST_CHAIN_TAG specified
Specific updates (required)
adds
--build-arg HIGHEST_CHAIN_TAGto locadocker targetHow did you test each of these updates (required)
Manually
Does this pull request close any open issues?
Fixes #1338
Checklist:
./test.shpass