eth: prefill last seen block state in timewatcher #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
requested changes
Mar 24, 2020
yondonfu
requested changes
Mar 26, 2020
yondonfu
requested changes
Mar 26, 2020
|
I see everything has been marked as resolved, can I rebase ? |
yondonfu
reviewed
Mar 30, 2020
kyriediculous
force-pushed
the
nv/last-round-nil
branch
from
af853a1
to
06cdd91
Compare
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Prefetch the state for
lastSeenBlockin the timewatcher to prevent nil pointer errors when no blocks have elapsed and thus the state isn't populated through backfillingSpecific updates (required)
timeWatcher.Watch()How did you test each of these updates (required)
Added unit tests
Does this pull request close any open issues?
Fixes #1420
Checklist:
./test.shpass