Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LIFO nvidia stack. #1444

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Remove LIFO nvidia stack. #1444

merged 2 commits into from
Apr 10, 2020

Conversation

j0sh
Copy link
Contributor

@j0sh j0sh commented Apr 9, 2020

What does this pull request do? Explain your changes. (required)
Removes the LIFO nvidia stack that was introduced in #1364 . No longer needed since livepeer/lpms#179 improves perf enough that serialization is no longer necessary.

Specific updates (required)

How did you test each of these updates (required)

Manual testing

Does this pull request close any open issues?

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@j0sh
Copy link
Contributor Author

j0sh commented Apr 10, 2020

e55a15b Updated LPMS to incorporate livepeer/lpms#184 (needs to be merged first, then will finalize the fixup here)

Unnecessary with latest round of LPMS performance improvements.
@j0sh j0sh merged commit 3eb536a into master Apr 10, 2020
@j0sh j0sh deleted the ja/revertstack branch April 10, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcoding broken with nvidia and standalone T
3 participants