Enable/disable HTTP ingest #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iameli
reviewed
Apr 12, 2020
server/mediaserver.go
Outdated
| @@ -578,6 +585,11 @@ func getRTMPStreamHandler(s *LivepeerServer) func(url *url.URL) (stream.RTMPVide | |||
|
|
|||
| // HandlePush processes request for HTTP ingest | |||
| func (s *LivepeerServer) HandlePush(w http.ResponseWriter, r *http.Request) { | |||
| if !s.HTTPIngest { | |||
| respondWith400(w, "HTTP ingest is disabled") | |||
There was a problem hiding this comment.
Arguably an HTTP 405 "Method Not Allowed" but idk if we observe that sort of thing at all in go-livepeer
j0sh
suggested changes
Apr 13, 2020
j0sh
reviewed
Apr 14, 2020
yondonfu
force-pushed
the
yf/http-ingest-flag
branch
from
f51a50b
to
1e079cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR enables/disables HTTP ingest according to the following rules:
-httpAddruses a non-local host) and there is no authentication webhook URL specified then HTTP ingest is disabled-authWebhookUrl-httpIngestSpecific updates (required)
See commit history for a description of each update.
How did you test each of these updates (required)
Updated unit tests and tested manually.
Does this pull request close any open issues?
Fixes #1441
Checklist:
./test.shpass