server: fix EthChainID webserver endpoint in offchain mode to return 'offchain' instead of '0' #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
reviewed
Apr 20, 2020
yondonfu
reviewed
Apr 20, 2020
…'offchain' instead of '0'
kyriediculous
force-pushed
the
nv/fix-cli-offchain
branch
from
f24a49c
to
8c3dc09
Compare
|
rebased ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes a bug whereby the
EthChainIDwebserver handler returns "0" when offchain , but the actual check compares against the string literal "offchain"go-livepeer/server/webserver.go
Line 1077 in c4a3004
go-livepeer/cmd/livepeer_cli/livepeer_cli.go
Line 173 in c4a3004
Specific updates (required)
How did you test each of these updates (required)
adjusted & ran unit tests
ran reproduction steps in CLI (run in offchain mode, then run CLI)
Does this pull request close any open issues?
Fixes #1378
Checklist:
./test.shpass