pm: check winning ticket transactions until confirm or error #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyriediculous
force-pushed
the
nv/pending-tickets
branch
from
ab96872
to
da4ae08
Compare
|
@kyriediculous I don't think this PR is necessary any more since #1923 has been merged right? |
|
That's right !
…On Mon, Jul 19, 2021 at 4:16 PM Yondon Fu ***@***.***> wrote:
@kyriediculous <https://github.com/kyriediculous> I don't think this PR
is necessary any more since #1923
<#1923> has been merged right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1880 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFJZZWQ53UQ6J4MY2VY2X53TYQXSDANCNFSM44Y62MIQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Don't return from
senderMonitor.redeemWinningTicketwhen context times out, loop instead until a concrete response is returned (other error or non-nil tx)How did you test each of these updates (required)
Does this pull request close any open issues?
Fixes #1806
Checklist:
makeruns successfully./test.shpass