Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Simplify detection webhook shapes #1922

Merged
merged 4 commits into from
Jun 20, 2021

Conversation

jailuthra
Copy link
Contributor

@jailuthra jailuthra commented Jun 17, 2021

What does this pull request do? Explain your changes. (required)

Simplify detection webhook shapes - for both stream-wide configuration via auth webhook and segment-wise results via detection webhook.

Specific updates (required)

see commit history

How did you test each of these updates (required)

Updated unit test for authwebhook -> detector configuration.

Manual testing for detection results webhook:

{"manifestID":"test","seqNo":0,"sceneClassification":[{"name":"soccer","probability":0.557692289352417},{"name":"adult","probability":0}]}
{"manifestID":"test","seqNo":4,"sceneClassification":[{"name":"soccer","probability":1},{"name":"adult","probability":0}]}
{"manifestID":"test","seqNo":8,"sceneClassification":[{"name":"soccer","probability":1},{"name":"adult","probability":0}]}
{"manifestID":"test","seqNo":12,"sceneClassification":[{"name":"soccer","probability":1},{"name":"adult","probability":0}]}
{"manifestID":"test","seqNo":16,"sceneClassification":[{"name":"soccer","probability":0.9193333387374878},{"name":"adult","probability":0}]}

Does this pull request close any open issues?

Fixes #1917

Depends upon
Some changes in LPMS livepeer/lpms@b196bda which are currently a part of a working branch (jai/adddnn).
But we can ignore the dependency for now, as the target for this PR is also a working branch (jai/e2e-detection)

Checklist:

@jailuthra jailuthra linked an issue Jun 17, 2021 that may be closed by this pull request
@jailuthra jailuthra marked this pull request as ready for review June 17, 2021 17:00
server/broadcast.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
server/mediaserver.go Outdated Show resolved Hide resolved
server/mediaserver.go Outdated Show resolved Hide resolved
core/streamdata.go Show resolved Hide resolved
server/mediaserver.go Outdated Show resolved Hide resolved
server/broadcast.go Outdated Show resolved Hide resolved
server/mediaserver.go Outdated Show resolved Hide resolved
@jailuthra jailuthra requested a review from yondonfu June 18, 2021 11:37
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squashing

@jailuthra jailuthra merged commit e47493b into jai/e2e-detection Jun 20, 2021
@jailuthra jailuthra deleted the jai/detection-webhooks branch June 20, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

finalize detection webhook JSON shapes
2 participants