-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Separate pipeline for tensorflow-enabled linux builds #1926
Conversation
5e3783b
to
edb5f31
Compare
a651b2a
to
3aa0d8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of my current understanding of the CI process:
- Linux
- Tensorflow Build
- Always enables Tensorflow. User will need to download libtensorflow themselves to use with the binary
- Only enables scene classification capability for non-semver tagged releases
- Regular Build
- Never enables Tensorflow
- Only enables scene classification capability for non-semver tagged releases
- Since Tensorflow is never enabled, scene classification can be enabled for a non-semver tagged release, but will not actually work
- Tensorflow Build
- Docker
- Always enables Tensorflow and libtensorflow is included in the image
- Only enables scene classification capability for non-semver tagged releases
- Windows
- Never enables Tensorflow
- Only enables scene classification capability for non-semver tagged releases
- Since Tensorflow is never enabled, scene classification can be enabled for a non-semver tagged release, but will not actually work
- Darwin
- Never enables Tensorflow
- Only enables scene classification capability for non-semver tagged releases
- Since Tensorflow is never enabled, scene classification can be enabled for a non-semver tagged release, but will not actually work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to make sure we're on the same page about this comment.
Other than that LGTM after squashing.
Thanks for the summary, and yeah that sounds about right! |
3aa0d8c
to
3b3e3c7
Compare
What does this pull request do? Explain your changes. (required)
Separate out the build process when
libtensorflow
is enabled.Specific updates (required)
see commit history
How did you test each of these updates (required)
The CI builds + uploads work as expected.
https://build.livepeer.live/0.5.18-3aa0d8ca/livepeer-linux-tensorflow-amd64.tar.gz <-- Depends on libtensorflow.so -
ldd livepeer | grep tensorflow
https://build.livepeer.live/0.5.18-3aa0d8ca/livepeer-linux-amd64.tar.gz <-- Standard build with no runtime dependency
Does this pull request close any open issues?
Fixes #1919
Checklist:
make
runs successfully./test.sh
pass