Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth,monitor: min/max gas price logs #1942

Merged
merged 1 commit into from Jul 8, 2021
Merged

Conversation

kyriediculous
Copy link
Contributor

@kyriediculous kyriediculous commented Jul 1, 2021

What does this pull request do? Explain your changes. (required)
Adds monitor statements for min and max gas price

Specific updates (required)

  • Added necessary logic to monitor package
  • Emit logs from min and max gas price setters if monitoring is enabled

How did you test each of these updates (required)

Does this pull request close any open issues?
Partially fixes https://github.com/livepeer/livepeer-infra/issues/578

Checklist:

@yondonfu
Copy link
Member

yondonfu commented Jul 1, 2021

@kyriediculous Looks like this PR records metrics for the min/max gas price, but livepeer/livepeer-infra#578 is related to the max transcoding price on the broadcaster. So, separate PR(s) will be needed to address that issue.

@kyriediculous
Copy link
Contributor Author

@kyriediculous Looks like this PR records metrics for the min/max gas price, but livepeer/livepeer-infra#578 is related to the max transcoding price on the broadcaster. So, separate PR(s) will be needed to address that issue.

Right sorry, got things mixed up again there. Let me add that momentarily.

Base automatically changed from yf/custom-min-gas-price to master July 1, 2021 15:48
eth/gaspricemonitor.go Show resolved Hide resolved
eth/backend.go Show resolved Hide resolved
eth/client.go Outdated Show resolved Hide resolved
eth/gaspricemonitor.go Outdated Show resolved Hide resolved
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyriediculous kyriediculous merged commit 8ab99c7 into master Jul 8, 2021
@kyriediculous kyriediculous deleted the nv/minmax-gp-log branch July 8, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants