transcoder: Enable B-frames in Nvidia encoder #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdarkdragon
force-pushed
the
it/return-zero-frame
branch
2 times, most recently
from
e97d743
to
41a2c60
Compare
jailuthra
force-pushed
the
jai/bframes-gpu
branch
from
df90472
to
9eff6bf
Compare
yondonfu
approved these changes
Jul 7, 2021
jailuthra
force-pushed
the
jai/bframes-gpu
branch
from
9eff6bf
to
f433b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Pull in changes from livepeer/lpms#243 around enabling B-frames for Nvidia encoder
Specific updates (required)
see commits
How did you test each of these updates (required)
Local testing with pushing segments in with the following transcoding options, and verifying output renditions have the expected H264 profiles/B-frames.
[ { "name": "240p0", "fps": 0, "profile": "H264High", "bitrate": 250000, "width": 426, "height": 240 }, { "name": "360p0", "fps": 0, "profile": "H264ConstrainedHigh", "bitrate": 800000, "width": 640, "height": 360 }, { "name": "480p0", "fps": 0, "profile": "H264Main", "bitrate": 1600000, "width": 854, "height": 480 }, { "name": "720p0", "fps": 0, "profile": "H264Baseline", "bitrate": 3000000, "width": 1280, "height": 720 } ]Does this pull request close any open issues?
Fixes #1941
Checklist:
makeruns successfully./test.shpass