Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extremely long delay before uploaded segment gets transcoded #1950

Merged
merged 2 commits into from Jul 9, 2021

Conversation

darkdarkdragon
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Fixes stuck HasZeroVideoFrameBytes function.

Specific updates (required)
mod: Update LPMS to livepeer/lpms@0054a3b

How did you test each of these updates (required)
Unit test in LPMS

Does this pull request close any open issues?
Fixes #1949

Checklist:

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left one comment about CHANGELOG_PENDING. Feel free to address and then merge.

@@ -21,6 +21,7 @@
- \#1934 http push: return 422 for non-retryable errors (@darkdarkdragon)
- \#1933 server: Return 0 video frame segments unchanged
- \#1943 log maximum transcoding price when monitoring is enabled (@kyriediculous)
- \#1950 Fix extremely long delay before uploaded segment gets transcoded (@darkdarkdragon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under the Broadcaster section in "Bug Fixes".

@darkdarkdragon darkdarkdragon merged commit 34ccf04 into master Jul 9, 2021
@darkdarkdragon darkdarkdragon deleted the it/has-zero-frames-fix branch July 9, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extremely long delay before uploaded segment gets transcoded
2 participants