Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Allows Os receive payments while pending activation #2146

Merged
merged 4 commits into from
Dec 30, 2021
Merged

core: Allows Os receive payments while pending activation #2146

merged 4 commits into from
Dec 30, 2021

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Dec 21, 2021 •
edited

What does this pull request do? Explain your changes. (required)
Allow receiving payments by orchestrator which is not yet activated (but will be activated in the next round).

Specific updates (required)
N/A

How did you test each of these updates (required)

  1. Set up local geth
  2. Set up Broadcaster and Orchestrator
  3. Manually updated SQLite DB for Orchester to modify acivationRound
  4. Check that the segments are still transcoded when the current round is activationRound - 1, but are not transcoded when the current round is activationRound - 2.

Does this pull request close any open issues?
fix #2140

Checklist:

@leszko leszko changed the title core: Allows Os received payments while pending activation core: Allows Os receive payments while pending activation Dec 21, 2021
@leszko leszko mentioned this pull request Dec 21, 2021
Closed
yondonfu
yondonfu reviewed Dec 22, 2021
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two minor comments.

core/orch_test.go Show resolved Hide resolved
core/orch_test.go Show resolved Hide resolved
leszko
leszko commented Dec 27, 2021
View reviewed changes
Copy link
Contributor Author

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @yondonfu I addressed your comments. PTAL.

@leszko leszko requested a review from yondonfu December 27, 2021 10:46
yondonfu
yondonfu approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

darkdarkdragon
darkdarkdragon approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yondonfu yondonfu merged commit 02a3c5f into livepeer:master Dec 30, 2021
@leszko leszko mentioned this pull request Feb 15, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdarkdragon darkdarkdragon darkdarkdragon approved these changes

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Os to receive tickets when they are pending activation
3 participants
@leszko @darkdarkdragon @yondonfu