Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth: Fix nil pointer in client.Vote() #2227

Merged
merged 2 commits into from
Feb 3, 2022
Merged

eth: Fix nil pointer in client.Vote() #2227

merged 2 commits into from
Feb 3, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Feb 3, 2022 •
edited

What does this pull request do? Explain your changes. (required)

Fix nil pointer when calling client.Vote()

Specific updates (required)

How did you test each of these updates (required)

  • Run vote before the chance (it crashed with nil pointer)
  • Run after - no crash observed

Does this pull request close any open issues?

Checklist:

yondonfu
yondonfu approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leszko leszko merged commit 8efdade into livepeer:master Feb 3, 2022
@leszko leszko deleted the fix-vote-nil branch February 3, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yondonfu yondonfu yondonfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leszko @yondonfu