Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail fast for Arbitrum One Mainnet when LIP-73 has not been activated yet #2251

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Feb 10, 2022

Temporarily add fail fast for Arbitrum One Mainnet when LIP-73 has not been activated yet.

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

  1. Tried to run on Arbitrum One Mainnet.
$ ./livepeer -network some-network -ethUrl https://arb1.arbitrum.io/rpc -orchestrator -transcoder
I0210 11:27:16.716149   90877 livepeer.go:260] ***Livepeer is running on the some-network network***
E0210 11:27:17.675315   90877 livepeer.go:436] LIP-73 has not been activated yet

Changed lip37Block to the current Mainnet block number 14177801

$ ./livepeer -network some-network-2 -ethUrl https://arb1.arbitrum.io/rpc -orchestrator -transcoder
I0210 11:29:51.028816   91068 livepeer.go:260] ***Livepeer is running on the some-network-2 network***
I0210 11:29:52.149630   91068 accountmanager.go:72] Using Ethereum account: 0x416BE189c67c58257E8867cdB41d55986127E76f
I0210 11:29:52.647704   91068 accountmanager.go:95] Please enter the passphrase to unlock Ethereum account 0x416BE189c67c58257E8867cdB41d55986127E76f
Passphrase: 
I0210 11:29:55.646791   91068 accountmanager.go:106] Unlocked ETH account: 0x416BE189c67c58257E8867cdB41d55986127E76f
E0210 11:29:55.825268   91068 client.go:198] Error getting LivepeerToken address: execution reverted
E0210 11:29:55.825300   91068 livepeer.go:496] Failed to set gas info on Livepeer Ethereum Client: execution reverted

Does this pull request close any open issues?

fix #2247

Checklist:

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing the typo

@@ -418,6 +418,26 @@ func main() {
return
}

// TODO: Remove after LIP-73 block (Arbitrum L2 contracts are unpaused)
arbitrumOneChainId := big.NewInt(42161)
lip37Block := big.NewInt(14207040)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lip37Block := big.NewInt(14207040)
lip73Block := big.NewInt(14207040)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@leszko leszko merged commit e50a775 into livepeer:master Feb 10, 2022
@leszko leszko deleted the 2247-fail-fast-arbitrum-one branch February 10, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return error on startup if connected to arbitrum-one-mainnet when L1 block < LIP-73 block
2 participants