Redeem tickets only when recipient is active

[leszko]

What does this pull request do? Explain your changes. (required)

Check if the recipient is active before redeeming the ticket.

Specific updates (required)

How did you test each of these updates (required)

The same testing as described here.

This time, when the orchestrator was inactive, this was the message (only with debug logs enabled):

I0210 15:34:23.237192   26302 queue.go:134] Ticket recipient is not active in this round, cannot redeem ticket recipientRandHash=59c006119dccedb68bff820c2754ad7662f6ceb7f23310cad52c272b74872bcb senderNonce=1

When the orchestrator became active, it redeemed the ticket.

******************************Eth Transaction******************************

Invoking transaction: "redeemWinningTicket". Inputs: "_ticket: { Recipient: 0x7E71B5087bc14abd6aF3Bbe2d87Ea0ADC14Ce56F  Sender: 0x7E71B5087bc14abd6aF3Bbe2d87Ea0ADC14Ce56F  FaceValue: 34782608695652173  WinProb: 33290225655728407058145081652868458784123513979168705244586300000000000000000  SenderNonce: 1  RecipientRandHash: 0x59c006119dccedb68bff820c2754ad7662f6ceb7f23310cad52c272b74872bcb  AuxData: 0x0000000000000000000000000000000000000000000000000000000000008414ecc7d83d923df7611fcda8bd67cc2aca904939e4b8417a1bc5f91e0d8487119d }  _sig: 0x27f8f5a6a08a5e3caac9bae27851d79ae69a67c9d7b63c080a138d846100f4d56970305363598c24994e7d84a1293437af869bc896948e19b89c2a5eb9a6199c1b  _recipientRand: 33683099207914901971858567325965190760487315520271124299464254139206992337416"  Hash: "0xf161f1db583a99d40efdaff72400f8f8e35590103ccd8dba36564eb425f4dcff". 

***************************************************************************

Does this pull request close any open issues?

fix #2250

Checklist:

• Read the contribution guide
• make runs successfully
• All tests in ./test.sh pass
• README and other documentation updated
• Pending changelog updated

[yondonfu]

Is the idea here to bias towards trying to redeem if there is an error with the DB because that's preferable to not redeeming since gas estimation for the tx should still prevent the tx from going on-chain even if the recipient actually happens to not be active?

[leszko]

Yes, it's a corner case that the DB returns an error, but still...

I think it makes more sense in uncertain scenarios to try to redeem the ticket because it may expire.

[yondonfu]

LGTM