Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce number metrics #2274

Merged
merged 1 commit into from
Feb 17, 2022
Merged

reduce number metrics #2274

merged 1 commit into from
Feb 17, 2022

Conversation

darkdarkdragon
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Reduces number of metrics datapoints

Specific updates (required)

  • removed segment_transcoded_appeared_total and transcode_latency_seconds metrics (they was per transcoding profile and so not useful, we do have corresponding overall metrics)
  • record upload_time_seconds and discovery_errors_total metrics per orchestrator and not per stream

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

figintern
figintern approved these changes Feb 17, 2022
View reviewed changes
Copy link

@figintern figintern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkdarkdragon darkdarkdragon merged commit a9e5bcd into master Feb 17, 2022
@darkdarkdragon darkdarkdragon deleted the it/metrics-improve branch February 17, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figintern figintern figintern approved these changes

@victorges victorges Awaiting requested review from victorges

@iameli iameli Awaiting requested review from iameli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darkdarkdragon @figintern