Add timeouts to eth client #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
reviewed
Feb 28, 2022
| minterSess *contracts.MinterSession | ||
| livepeerTokenFaucetSess *contracts.LivepeerTokenFaucetSession | ||
| // Contracts | ||
| controller *contracts.Controller |
There was a problem hiding this comment.
Like the refactor, but is this related to the timeouts change? Seems to be the bulk of the PR here.
There was a problem hiding this comment.
It is related because before adding the timeout, we actually needed to store sessions here (CallOpts was encapsulated in the session structs). Now, we don't need sessions, because we always provide our CallOpts.
There was a problem hiding this comment.
Cool! Thanks for clarification
eth/client.go
Outdated
| @@ -1101,6 +1089,8 @@ func (c *client) CheckTx(tx *types.Transaction) error { | |||
|
|
|||
| for { | |||
| select { | |||
| case <-time.After(c.checkTxTimeout): | |||
There was a problem hiding this comment.
I believe you actually need to create the time.After timer only once, outside the for loop, otherwise you will reset the timer for every receipt that you get even if not related to the tx you're checking.
yondonfu
reviewed
Mar 1, 2022
leszko
force-pushed
the
2207-add-timeouts-to-pubsub
branch
from
ee6a8c1
to
adeb060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Add timeouts for
CheckTx()function and all ETH RPC calls.Note that the timeout values are quite conservative, by default:
CheckTx()I don't think we need smaller numbers, because in the correct flow of action, these timeouts should never actually be reached.
Specific updates (required)
CheckTx()executionHow did you test each of these updates (required)
CheckTxTimeoutto 1 ns and check that it always times outethRpcTimeoutto 1 ns and check that all ETH RPC requests failDoes this pull request close any open issues?
fix #2207
Checklist:
makeruns successfully./test.shpass