Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Split Auth/Webhook functionality into its own file and add tests #2326

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented Mar 17, 2022

What does this pull request do? Explain your changes. (required)
Break auth out into its own file, reducing the amount of code in mediaserver.go and add tests ahead of upcoming Mist integration work

Specific updates (required)

  • Split auth method into its own file
  • Remove references to global variable from within the file (accept parameter instead)
  • Add unit test coverage of auth

How did you test each of these updates (required)

  • Ran test suite

Does this pull request close any open issues?
No

Checklist:

Copy link
Contributor

@oscar-davids oscar-davids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomshutt thomshutt merged commit 56cabb3 into master Mar 18, 2022
@thomshutt thomshutt deleted the auth-refactor branch March 18, 2022 15:44
ad-astra-video pushed a commit to ad-astra-video/go-livepeer that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants