Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livepeer_cli: Improve user feedback when specifying numeric values for some wizard options #2345

Merged
merged 6 commits into from
Mar 31, 2022

Conversation

kparkins
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
This PR addresses issues outlined in Issue #1602 relating to poor user experience in the livepeer_cli when specifying numeric values for some wizard options (gas price, bonding, unbonding, and transfer amount). In particular, it attempts to provide better feedback to the user when invalid values are supplied.

Specific updates (required)

  • Add prompt parameter to readBigInt in wizard.go and change to log an error when parsing an int fails.
  • Update calls to readBigInt to pass a relevant prompt.

How did you test each of these updates (required)

  • Ran all unit tests (PASSED)
  • Tested the CLI manually for each of the affected options.

Does this pull request close any open issues?

Checklist:

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the PR @kparkins . I think it'll be a good improment. Added a very minor comments, please take a look.

CHANGELOG_PENDING.md Outdated Show resolved Hide resolved
cmd/livepeer_cli/wizard.go Outdated Show resolved Hide resolved
cmd/livepeer_cli/wizard_bond.go Outdated Show resolved Hide resolved
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the PR @kparkins

@leszko leszko merged commit e297ba1 into livepeer:master Mar 31, 2022
ad-astra-video pushed a commit to ad-astra-video/go-livepeer that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

livepeer_cli gas price validation
2 participants